Skip to content

use getBoundingClientRect to account for decimals in container size #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bodymovin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use getBoundingClientRect to account for decimals in container size #260

bodymovin wants to merge 2 commits into from
+38 −18

Conversation

@bodymovin
Copy link
Contributor

@bodymovin bodymovin commented May 28, 2024 •
edited
Loading

clientWidth and clientHeight return element size without the decimals.
getBoundingClientRect instead returns a more precise size that we can use to make sure the canvas is not slightly smaller than the container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HayesGordon HayesGordon Awaiting requested review from HayesGordon

@damzobridge damzobridge Awaiting requested review from damzobridge

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bodymovin