Skip to content

Fix: Prevent scrollbars from flashing on resize #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lancesnider wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent scrollbars from flashing on resize #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hooks/useRive.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function RiveComponent({
const containerStyle = {
width: '100%',
height: '100%',
overflow: 'hidden',
...style,
};

Expand Down
2 changes: 2 additions & 0 deletions test/useRive.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ describe('useRive', () => {
<RiveTestComponent className="rive-test-clas" style={{ width: '50%' }} />
);
expect(container.firstChild).not.toHaveStyle('width: 50%');
expect(container.firstChild).not.toHaveStyle('overflow: hidden');
});

it('has a canvas size of 0 by default', async () => {
Expand All @@ -454,6 +455,7 @@ describe('useRive', () => {
const { RiveComponent: RiveTestComponent } = result.current;
const { container } = render(<RiveTestComponent />);
expect(container.querySelector('canvas')).toHaveStyle('width: 0');
expect(container.firstChild).toHaveStyle('overflow: hidden');
});

it('sets the canvas width and height after calculating the container size', async () => {
Expand Down
Loading