Added more build options for 3d party users #75

JCash · 2025-11-14T14:06:19Z

sysroot - for telling the build where the sysroot actually is
with_pthread - to be able to build WASM with pthread support
NDK_LONG_VERSION_STRING - highlight the need for configurable NDK values
Linux target `cross compilation support
with-libs-only - to be able to just build the runtime libraries and skip everything else.

csmartdalton

These are awesome changes @JCash ! Thank you for taking this on!

csmartdalton · 2025-11-21T16:42:12Z

renderer/premake5_pls_renderer.lua

+newoption({
+    trigger = 'with-libs-only',
+    description = 'only builds the libraries',
+})


I don't think this should be necessary. If you want to build just a library, you can already say:

build_rive.sh -- rive_pls_renderer

While I just verified that it is indeed possible to do, there are still major flaws with that approach:

Documentation. There is no clear documentation as to which libraries are needed in order to link an executable.

Robustness. There have been numerous updates (breaking changes) where the list (and names) of these libraries change.

So, in all fairness, I think the notion of a "build libraries only" target is still very much needed here.

csmartdalton · 2025-11-21T16:43:18Z

build/rive_build_config.lua

+    local host_arch = os.outputof('uname -m') or ''
+
+    -- Apply target triple if host arch doesn't match requested arch
+    if _OPTIONS['arch'] == 'x64' and host_arch ~= 'x86_64' then


Thanks for handling these. Can we add x86, just for completeness?

I'll try adding it.

csmartdalton · 2025-11-21T16:43:46Z

build/rive_build_config.lua

+    end
+
+    -- Optional sysroot
+    if _OPTIONS['sysroot'] ~= nil then


Should we apply the sysroot outside of the linux branch? It might be confusing if someone tries to specify a sysroot for a non-linux build.

Hmm, looking at my code, I don't think I even use it anymore. I'll verify removing it. 🤔

csmartdalton · 2025-11-21T16:44:28Z

build/rive_build_config.lua

    -- Detect the NDK.
    local EXPECTED_NDK_VERSION = 'r27c'
-    local NDK_LONG_VERSION_STRING = "27.2.12479018"
+    local NDK_LONG_VERSION_STRING = "25.2.9519653"


Thanks for calling attention to this! @ErikUggeldahl can probably suggest how we should handle it.

Hmm, looks like this wasn't fully handled. Right now it's 27 to match with Rive Android's expected build. By changing this, we will likely clash. I could see adding a parameter to change it if necessary, but just changing it like this is likely to cause issues.

Additionally:

This no longer matches the EXPECTED variable above.

This version does not support 16KB page sizes by default. By dropping <26, you would need to ensure the advised build flags are enabled.

Yeah, this entire PR is highlighting customer hot spots. So, what we likely need is a good way to specify the NDK/SDK version. I'm not sure what is the best way to do it, but basically something like this is a common approach:

export ANDROID_SDK_ROOT=/path/to/android/sdk export ANDROID_NDK_ROOT=/path/to/android/ndk export ANDROID_ABI=arm64-v8a export ANDROID_PLATFORM=android-21 export ANDROID_TOOLCHAIN=clang export ANDROID_STL=c++_shared

And then you will of course have your own defaults.

ErikUggeldahl

Just reviewing the NDK version change, but I think it needs some additional thought.

ErikUggeldahl · 2025-11-21T18:32:14Z

build/rive_build_config.lua

    -- Detect the NDK.
    local EXPECTED_NDK_VERSION = 'r27c'
-    local NDK_LONG_VERSION_STRING = "27.2.12479018"
+    local NDK_LONG_VERSION_STRING = "25.2.9519653"


Hmm, looks like this wasn't fully handled. Right now it's 27 to match with Rive Android's expected build. By changing this, we will likely clash. I could see adding a parameter to change it if necessary, but just changing it like this is likely to cause issues.

Additionally:

This no longer matches the EXPECTED variable above.

This version does not support 16KB page sizes by default. By dropping <26, you would need to ensure the advised build flags are enabled.

JCash · 2025-11-22T10:18:27Z

build/rive_build_config.lua

+    end
+
+    -- Optional sysroot
+    if _OPTIONS['sysroot'] ~= nil then


Hmm, looking at my code, I don't think I even use it anymore. I'll verify removing it. 🤔

JCash · 2025-11-22T10:18:57Z

build/rive_build_config.lua

+    local host_arch = os.outputof('uname -m') or ''
+
+    -- Apply target triple if host arch doesn't match requested arch
+    if _OPTIONS['arch'] == 'x64' and host_arch ~= 'x86_64' then


I'll try adding it.

JCash · 2025-11-22T10:19:40Z

renderer/premake5.lua


 newoption({ trigger = 'with-skia', description = 'use skia' })
-if _OPTIONS['with-skia'] then
+if _OPTIONS['with-skia'] and not _OPTIONS['with-libs-only'] then


This approach may be obsolete with the workaround Chris suggested.

JCash · 2025-11-22T10:22:58Z

renderer/premake5_pls_renderer.lua

+newoption({
+    trigger = 'with-libs-only',
+    description = 'only builds the libraries',
+})


While I just verified that it is indeed possible to do, there are still major flaws with that approach:

Documentation. There is no clear documentation as to which libraries are needed in order to link an executable.

Robustness. There have been numerous updates (breaking changes) where the list (and names) of these libraries change.

So, in all fairness, I think the notion of a "build libraries only" target is still very much needed here.

JCash · 2025-11-24T13:38:11Z

build/rive_build_config.lua

+-- Always build position independent code on Linux
+-- Ensures static libs can link into shared objects without relocation errors.
+filter({ 'system:linux' })
+do
+    pic('on')
+    buildoptions({ '-fPIC' })
+    linkoptions({ '-fPIC' })
+end


I tried using the "--with-pic" option, but it seems it didn't apply to everything required 🤷

Added way to build only libraries

c32aabf

csmartdalton reviewed Nov 21, 2025

View reviewed changes

ErikUggeldahl requested changes Nov 21, 2025

View reviewed changes

JCash commented Nov 22, 2025

View reviewed changes

JCash added 2 commits November 22, 2025 11:52

review changes

7355545

readded -fPIC to linux

8a6cca2

JCash commented Nov 24, 2025

View reviewed changes

Added more build options for 3d party users #75

Are you sure you want to change the base?

Added more build options for 3d party users #75

Uh oh!

Conversation

JCash commented Nov 14, 2025

Uh oh!

csmartdalton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ErikUggeldahl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants