Support if_not_exists on add_index_on_all_partitions
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alachaum
force-pushed
the
support-index-if-not-exists
branch
from
ab81e0b to
90daab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rkrage , thanks for maintaining this gem. It really makes using partitioning a breeze 🥇
This PR adds support for the
if_not_exists: trueoption when usingadd_index_on_all_partitions, similar to what Rails provides onadd_index. Theif_not_existsgets cascaded to the sub-tables, meaning that the whole operation can be resumed where it was left off in the event of an error, timeout etc.Rationale
We're in a situation where we need to run long-running migrations in background jobs, which also means we need to deal with job timeouts. And because we have a fair amount of data, those timeouts are expected (since the
concurrentlyoption is synchronous from a connection perspective). Restarting a migration from scratch on error or timeout is not a viable option.The
if_not_existsapproach, combined with theconcurrentlyoption, gives us the ability to have resilient migration jobs that resume themselves and create indexes progressively.We already use this approach with regular tables, and it would be great to have the same with partitioned tables 🚀