Skip to content

Assembly Definition Define Constraints & Load Stylesheet by Guid... #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lordofduct wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Assembly Definition Define Constraints & Load Stylesheet by Guid... #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.rlabrecque.steamworks.net/Editor/Settings/EditorSteamworksNETSettingsElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ public sealed class EditorSteamworksNETSettingsElement : VisualElement

private const string UssFilePath =
"Packages/com.rlabrecque.steamworks.net/Editor/Settings/EditorSteamworksNETSettingsStyleSheet.uss";
private const string UssFileGuid = "fcba6a16ac8056e418e5f791a8bbb67c";

public EditorSteamworksNETSettingsElement()
{
_settings = EditorSteamworksNETSettings.Instance;
var styleSheet = AssetDatabase.LoadAssetAtPath<StyleSheet>(UssFilePath);
//var styleSheet = AssetDatabase.LoadAssetAtPath<StyleSheet>(UssFilePath);
var styleSheet = AssetDatabase.LoadAssetAtPath<StyleSheet>(AssetDatabase.GUIDToAssetPath(UssFileGuid));

if (styleSheet)
{
Expand Down
4 changes: 3 additions & 1 deletion com.rlabrecque.steamworks.net/Editor/com.rlabrecque.steamworks.net.editor.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"overrideReferences": true,
"precompiledReferences": [],
"autoReferenced": true,
"defineConstraints": [],
"defineConstraints": [
"UNITY_EDITOR"
],
"versionDefines": [],
"noEngineReferences": false
}
4 changes: 3 additions & 1 deletion com.rlabrecque.steamworks.net/Runtime/com.rlabrecque.steamworks.net.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"overrideReferences": true,
"precompiledReferences": [],
"autoReferenced": true,
"defineConstraints": [],
"defineConstraints": [
"UNITY_EDITOR || STEAMWORKS_NET"
],
Copy link
Owner

@rlabrecque rlabrecque Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dylan, one thing I am slightly concerned about is what this implies out of the box for non-editor packages. Our overall enabling/disabling situation in general probably needs a complete revisit, and I've honestly kind of lost track of say whether one has to pre-define STEAMWORKS_NET somewhere, or if it will get automatically defined [unless you disable it somehow?], etc. Any thoughts/insights? I won't really have time to look into this any time soon.

Aside from this piece the rest looks great.

Copy link
Author

@lordofduct lordofduct Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm.

So I've always leaned towards an opt-in approach to 3rd party libs. And I sort of just kind of assumed from the existence of STEAMWORKS_NET (or in the past it was just STEAMWORKS) that it implied this opt-in approach. But I do see looking through the package that it is automatic from the get go. This does mean that my change would break backwards compatibility. (though arguably the change from STEAMWORKS to STEAMWORKS_NET also broke backwards compatibility)

Maybe it could just be opt-out ala a DISABLE_STEAMWORKS_NET or something.

I just know every time I import the package I add this constraint (or equivalent) so I can make itch.io builds as well as steam builds since as-is the library assumes a Win/Linux/Mac build is a Steam build.

I'll have to think on it some more... maybe pick up this conversation a little later as I too am a bit busy right now as well.

"versionDefines": [],
"noEngineReferences": false
}