Skip to content

Comments

Fixes to ip socket argument, undefined graceful_disconnect, and added documentation for socket connections#27

Open
JRogaishio wants to merge 6 commits intornconrad:masterfrom
JRogaishio:master
Open

Fixes to ip socket argument, undefined graceful_disconnect, and added documentation for socket connections#27
JRogaishio wants to merge 6 commits intornconrad:masterfrom
JRogaishio:master

Conversation

@JRogaishio
Copy link

@JRogaishio JRogaishio commented May 13, 2023

Changes:

  • ip command was using the wrong index when sending the port number. Instead it was sending the string ip instead of the defined port number
  • graceful_disconnect is not defined and causes the project compile to fail
  • Added documentation for socket connections so it's clear what the project is expecting for UDP messages
  • Moved .md documentation to /docs folder to cleanup the project root. Also updated all the paths in README.md to use relative links so any forks point to their own documentation version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants