-
-
Notifications
You must be signed in to change notification settings - Fork 927
feat: Add line border properties to LineLayer #4107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Introduced `lineBorderWidth`, `lineBorderWidthTransition`, `lineBorderColor`, and `lineBorderColorTransition` properties to enhance line styling capabilities. - Updated Android and iOS implementations to support new properties. - Enhanced documentation to include descriptions and usage examples for the new line border attributes. This update allows for more customizable line styles in the mapping interface.
|
@Fl0h0 getting better 👍 . See ci failures, I think we need to solve v10 compatibility: Also on iOS: /Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1394:17: error: value of type 'LineLayer' has no member 'lineBorderWidth'
layer.lineBorderWidth = styleValue.mglStyleValueNumber();
~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1401:11: error: value of type 'LineLayer' has no member 'lineBorderWidthTransition'
layer.lineBorderWidthTransition = styleValue.getTransition();
~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1408:17: error: value of type 'LineLayer' has no member 'lineBorderColor'
layer.lineBorderColor = styleValue.mglStyleValueColor();
~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1415:11: error: value of type 'LineLayer' has no member 'lineBorderColorTransition'
layer.lineBorderColorTransition = styleValue.getTransition(); |
|
I'm also thinking on bumping version to 1.3.0 and supporting only v11 and new architure. To make things like this less painful |
|
@Fl0h0 Can you pls rebase, we now dropped mapbox 10 and old arch on main?! |
That's great, removing the need for all the version 10 checks. |
lineBorderWidth,lineBorderWidthTransition,lineBorderColor, andlineBorderColorTransitionproperties to enhance line styling capabilities.This update allows for more customizable line styles in the mapping interface.