Skip to content

Conversation

@Fl0h0
Copy link

@Fl0h0 Fl0h0 commented Dec 7, 2025

  • Introduced lineBorderWidth, lineBorderWidthTransition, lineBorderColor, and lineBorderColorTransition properties to enhance line styling capabilities.
  • Updated Android and iOS implementations to support new properties.
  • Enhanced documentation to include descriptions and usage examples for the new line border attributes.

This update allows for more customizable line styles in the mapping interface.

- Introduced `lineBorderWidth`, `lineBorderWidthTransition`, `lineBorderColor`, and `lineBorderColorTransition` properties to enhance line styling capabilities.
- Updated Android and iOS implementations to support new properties.
- Enhanced documentation to include descriptions and usage examples for the new line border attributes.

This update allows for more customizable line styles in the mapping interface.
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 7, 2025 17:23 — with GitHub Actions Error
@Fl0h0 Fl0h0 temporarily deployed to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Inactive
@Fl0h0 Fl0h0 temporarily deployed to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Inactive
@Fl0h0 Fl0h0 temporarily deployed to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Inactive
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Failure
@Fl0h0 Fl0h0 had a problem deploying to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Failure
@Fl0h0 Fl0h0 temporarily deployed to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Inactive
@Fl0h0 Fl0h0 temporarily deployed to CI with Mapbox Tokens December 9, 2025 10:14 — with GitHub Actions Inactive
@mfazekas
Copy link
Contributor

@Fl0h0 getting better 👍 .

See ci failures, I think we need to solve v10 compatibility:

e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1634:17 Unresolved reference 'lineBorderWidth'.
> Task :rnmapbox_maps:compileDebugKotlin
e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1641:19 Unresolved reference 'lineBorderWidth'.
e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1652:15 Unresolved reference 'lineBorderWidthTransition'.
e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1660:17 Unresolved reference 'lineBorderColor'.
e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1667:19 Unresolved reference 'lineBorderColor'.
e: file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleFactory.kt:1678:15 Unresolved reference 'lineBorderColorTransition'.

Also on iOS:

/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1394:17: error: value of type 'LineLayer' has no member 'lineBorderWidth'
          layer.lineBorderWidth = styleValue.mglStyleValueNumber();
          ~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1401:11: error: value of type 'LineLayer' has no member 'lineBorderWidthTransition'
    layer.lineBorderWidthTransition = styleValue.getTransition();
    ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1408:17: error: value of type 'LineLayer' has no member 'lineBorderColor'
          layer.lineBorderColor = styleValue.mglStyleValueColor();
          ~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1415:11: error: value of type 'LineLayer' has no member 'lineBorderColorTransition'
    layer.lineBorderColorTransition = styleValue.getTransition();

@mfazekas
Copy link
Contributor

I'm also thinking on bumping version to 1.3.0 and supporting only v11 and new architure. To make things like this less painful

@mfazekas
Copy link
Contributor

@Fl0h0 Can you pls rebase, we now dropped mapbox 10 and old arch on main?!

@Fl0h0 Fl0h0 requested a deployment to CI with Mapbox Tokens December 22, 2025 21:47 — with GitHub Actions Waiting
@Fl0h0 Fl0h0 requested a deployment to CI with Mapbox Tokens December 22, 2025 21:47 — with GitHub Actions Waiting
@Fl0h0 Fl0h0 requested a deployment to CI with Mapbox Tokens December 22, 2025 21:47 — with GitHub Actions Waiting
@Fl0h0
Copy link
Author

Fl0h0 commented Dec 22, 2025

@Fl0h0 Can you pls rebase, we now dropped mapbox 10 and old arch on main?!

That's great, removing the need for all the version 10 checks.
I merged the new changes in this branch so now it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants