Skip to content

chore(ts): export types CameraBoundsWithPadding, OnPressEvent #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mariusud wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ts): export types CameraBoundsWithPadding, OnPressEvent #4120

mariusud wants to merge 1 commit into from

Conversation

@mariusud
Copy link
Contributor

@mariusud mariusud commented Dec 15, 2025 •
edited
Loading

Description

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mariusud mariusud temporarily deployed to CI with Mapbox Tokens December 15, 2025 14:15 — with GitHub Actions Inactive
@mfazekas
Copy link
Contributor

mfazekas commented Dec 17, 2025

@mariusud thanks much for the PR, can you please write a short summary on why do you need those types,

@mariusud
Copy link
Contributor Author

mariusud commented Dec 17, 2025

@mariusud thanks much for the PR, can you please write a short summary on why do you need those types,

@mfazekas we were previously deep-importing these types, but after recent changes they’re no longer exposed. CameraBoundsWithPadding is used for setting camera-bounds with an added padding, and OnPressEvent is used to properly type some onPress handlers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mariusud @mfazekas