feat(ios): Remove Mapbox v10 legacy code, keep v11 only #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the #ifdef RNMBX_11 conditionals from iOS code, keeping only the v11 implementation as part of the 1.3.0 migration. Changes include: - Remove v10 code from offline module and legacy offline module - Clean up layer files (Circle, Fill, Line, Symbol, Heatmap, Raster, Model, Background, FillExtrusion, RasterParticle) - Clean up source files (Vector, Shape, Raster, RasterDem, Image, RasterArray) - Update style value helpers for v11-only types - Remove v10 location module, rename v11 version to main - Update component views (RasterParticle, RasterArraySource) - Clean up core components (Light, Atmosphere, Viewport, CustomHttpHeaders, MapViewManager, SnapshotModule) - Update code generation template (RNMBXStyle.swift.ejs) to not emit v11 conditionals - Update LayerPropsCommon.codepart-swift.ejs to not emit v11 conditionals This is part of the v11-only migration for @rnmapbox/maps 1.3.0. Note: Some files still have RNMBX_11 conditionals that require manual review (MapView, Camera, Layer base class, etc).
mfazekas
force-pushed
the
claude/remove-ios-legacy-code-nSSl7
branch
from
fa8c1e6 to
db09734
Compare
Continue the v10 to v11-only migration by removing all remaining #if RNMBX_11 conditionals and keeping only the v11 implementations. Files updated: - RNMBXMapView.swift: Remove v10 event handlers, feature state API, cancelables - RNMBXCamera.swift: Remove v10 NSNumber extension guard, bounds API, location auth - RNMBXLayer.swift: Remove v10 styleLayerExists, slot handling, setOptions - RNMBXCameraGestureObserver.swift: Remove v10 conditional gesture handling - RNMBXCustomLocationProvider.swift: Remove v10 location provider implementation - RNMBXImages.swift: Remove v10 hasImage implementation - RNMBXMarkerView.swift: Remove v10 ViewAnnotationOptions conditionals - RNMBXModels.swift: Remove v10 removeStyleModel conditional - RNMBXModule.swift: Remove v10 accessToken and clearData implementations - RNMBXSource.swift: Remove v10 addSource signature - RNMBXStyleImport.swift: Remove v10 setStyleImportConfigProperties guard This is part of the 1.3.0 migration that only supports Mapbox v11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the #ifdef RNMBX_11 conditionals from iOS code, keeping only the v11 implementation as part of the 1.3.0 migration.
Changes include:
This is part of the v11-only migration for @rnmapbox/maps 1.3.0. Note: Some files still have RNMBX_11 conditionals that require manual review (MapView, Camera, Layer base class, etc).
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing