Skip to content

Conversation

@sethgi
Copy link
Collaborator

@sethgi sethgi commented Apr 30, 2025

mainly added return_grads to batchZonotope.slice

also commented out a bug-inducing error check in compress.py

finally, ran a linter on batch_zono.py

@BuildingAtom
Copy link
Collaborator

Thanks, this looks good! Could you also add return_grads for zonotope.slice following that same form as well? I think we'll want to revisit the zonotope API's later, but that's a future thing.

As for the error check in compress.py. I took another look at it, and it seems like that was some internal leftover from checking downstream tasks for over-approximation, so we're good to remove it.

@BuildingAtom BuildingAtom self-requested a review May 5, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants