Skip to content

Conversation

@tntmarket
Copy link
Contributor

@tntmarket tntmarket commented Aug 30, 2020

This makes the panel navigation shortcuts more compatible for both the default Roam experience and horizontal themes (tntmarket#5):

Demo with vanilla theme: https://www.youtube.com/watch?v=jsGXeVCcAvc
Demo with horizontal theme: https://www.youtube.com/watch?v=tPkDJKHU4SY

This is not exactly "backwards compatible", because you can no longer navigate between sidebar pages with straight up j/k etc.

I feel like it matches the behavior of "vim windows" more closely though, and it makes it so gg and G go to the beginning/end of the sidebar page, rather than the whole sidebar.

@tntmarket tntmarket requested a review from Stvad August 30, 2020 00:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tntmarket
Copy link
Contributor Author

Hey @lkhphuc and @TDHTTTT, here's a demo of shortcuts that should work better with horizontal themes, what do you think? https://www.youtube.com/watch?v=tPkDJKHU4SY

@lkhphuc
Copy link

lkhphuc commented Aug 31, 2020

Hey that look nice. Thank @tntmarket . Looking forward to this.

@Stvad
Copy link
Member

Stvad commented Sep 13, 2020

I use the non-horizontal theme and I heavily use the navigation between panels, so I would not want to loose that =\

@tntmarket tntmarket force-pushed the navigate_between_sidebar_panels branch from f7a5ac1 to dadaa19 Compare October 11, 2020 19:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tntmarket
Copy link
Contributor Author

I use the non-horizontal theme and I heavily use the navigation between panels, so I would not want to loose that =\

Maybe we can have sidebar pages be separate panels, but make it so navigating past the current panel takes you to the next panel?

@Stvad
Copy link
Member

Stvad commented Oct 11, 2020

That should work, I think :)

@tntmarket tntmarket mentioned this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants