Ace integration #22
Ace integration #22
Conversation
…owever, it fails to properly render at start up, you need to resize the Workspace window to get it to render. also, all Workspace actions fail - they need to use the Ace APIs.
… use the Ace API. all functionality works as expected, and rendering is correct. yay! only polish work remains to be done
- include only the theme and mode we need. - include ChangeLog, LICENSE and Readme.md - remove the pilot/fixoldbrowsers module. - include a Dryice-based build script which builds Ace customized for Workspace. Overall, just one ace.js file needs to be included.
|
still not getting a context menu with this. Ace behavior seems better though. Still seeing errors showing up for lines such as: Is lint included in this? The insertion bug I was seeing creating new lines on first line is gone though. |
|
also seeing: In the error console after opening the workspace. |
Makefile
Outdated
There was a problem hiding this comment.
this directory isn't exactly generic. change to zip -r ../workspace.xpi * -x ".git/" -x "."...
|
Pretty much all problems reported are now fixed. Please review the changes and let me know if further changes are needed before you can close the pull request. Thanks! |
|
much-improved. Menu popup now works and no longer seeing red "error" highlighting on some chrome workspace text. No scrollbars on mac though. |
2 participants
This is the proposed Ace integration patch for Workspace.
Ace is built with a custom script, such that we exclude things we do not need. We need to mix XHTML and XUL, as part of the requirement to get Ace's code running.
I will make separate pull requests to ajaxorg's Ace code and to their pilot library, with fixes, patches I did to get it all running in Workspace.
Generally, Ace works as it does in a normal web app, so bugs you notice are just the usuals. :) If you find issues, please compare with their Ace demo.
Feedback is very much welcome, thanks!