Draft
Conversation
3f2ce5e to
eee9a1f
Compare
eee9a1f to
af035ad
Compare
af035ad to
eeb3153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert code to use C++ 20 features:
std::erase_ifinstead ofstd::remove_ifanderaseTo do
m_gravitational_constantfeels like it should be a variable in caps at the top of the filebodyNamesif possible?N-Body-Simulations/cpp/simulator/src/NBodySimulator.cpp
Line 249 in 0190c94