Skip to content

Don't throw notices if the response is for a failed connection #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomjn wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Don't throw notices if the response is for a failed connection #63

tomjn wants to merge 45 commits into from

Conversation

@tomjn
Copy link
Contributor

@tomjn tomjn commented Jan 21, 2014

No description provided.

@tomjn
Copy link
Contributor Author

tomjn commented Apr 27, 2014

A lot more was added, an admin page under tools that shows messages, moved class into its own file, and some logic to add messages showing when a build occurs, and why it occurred. This also gives any future WP File system code a place to redirect to

@roborourke
Copy link
Owner

roborourke commented Apr 28, 2014

Wow. Lot's of changes! Re. the admin page should we only show that if WP_DEBUG is true as it';s purely for developers?

@tomjn
Copy link
Contributor Author

tomjn commented Apr 28, 2014

It's currently only showing for administrators, I'd rather not rely on WP_DEBUG as this would be useful for production debugging

@tomjn tomjn mentioned this pull request May 2, 2014
Open
tomjn and others added 12 commits May 2, 2014 15:56
@tomjn
add a missing closing code tag in a message
899f49d
@tomjn
remove the wp_die, and return the original
bfedcf9
@tomjn
fix the wp die
53fc608
@tomjn
Merge branch 'master' of github.com:Tarendai/wp-less
ee9b32b
@scottsweb
Change compiler to less.php (https://github.com/oyejorge/less.php). O…
622541a 
…ne thing to note is that variables within URLs must be place within quotes "" as noted here: roborourke#67 (comment)
@tomjn
escape the log messages
89cef9d
@tomjn
escape wp_die message
6e37534
@tomjn
fix the comment from appearing red in GitHub
b53621c
@tomjn
Merge pull request #2 from scottsweb/master
800ef33 
Change compiler to less.php (https://github.com/oyejorge/less.php).
@tomjn
pull across some changes by @rmccue in the original wp less plugin
e466810
@tomjn
switch to md5 based check, and bring some other improvements over suc…
ea6c6eb 
…h as caching the upload url
@tomjn
bring across disabling of LESS compilation via an option by @joehoyle
cc0efc7
tomjn and others added 19 commits April 1, 2015 13:23
@tomjn
Bring across fixes by @johnbillion in https://github.com/johnbillion/…
37c4a9d 
…wp-less/commit/6a15b7a1080be98436011c899c24afbcd674bb45
@tomjn
fix authors json
c201fe0
Changed wp_kses to wp_strip_all_tags as wp_kses requires two args
7eb4313
Still requires you to create directory if it doesnt exist. Should not…
449895b 
… have been removed
Lets reach the if statement please
53de286
@tomjn
Merge pull request #3 from spacedmonkey/master
8c06f8c 
Fixes!
@spacedmonkey
Changed less.php version number
639006e 
Wasn't loading latest stable version of less.php.
@tomjn
Merge pull request #4 from TimeIncOSS/master
97365b0 
Changed less.php version number
@tomjn
Removed output of nonexistant var cache_path, fixes a warning
d5bc40a
@tomjn
Add 2 error messages and braces
fb5b6a4
@tomjn
closing semicolon
bfd87f4
@tomjn
Missing dot
a7f5e30
output a log message if the cache folder couldnt be created
df61d18
@tomjn
fixes a warning if the response body isn't set in the update check fi…
15d5cdb 
…lter
@tomjn
$r isn't an array, switch to isset for now in the update filter function
7911090
@tomjn
type hint $r to an array and use isset rather than !isset in the check
f1738e9
@tomjn
extract a variable out of an array lookup
85dd821
@tomjn
prevent a fatal error from happening with a temporary work around whe…
1e280d6 
…n filtering updates
@tomjn
switch the plugin update filter to be more reliable
92e1e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomjn @roborourke @spacedmonkey @scottsweb