137_new_Feature_test #524
Open
137_new_Feature_test #524
+688
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
362780316
requested review from
John-Robocore,
NextFuture,
Copilot and
zjn0505
362780316
force-pushed
the
137_new_Feature_test
branch
from
4178203 to
60ec495
Compare
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The button "Reset Map (Save Home)" (btnResetMap) defined in the layout has no click listener implementation in the activity.
Comment on lines
56
to
60
| android:id="@+id/btnTtsLangauges" | ||
| style="@style/ButtonCommon" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:text="TTS of all langauges" /> |
There was a problem hiding this comment.
The word "langauges" is misspelled. It should be "languages".
Suggested change
| android:id="@+id/btnTtsLangauges" | |
| style="@style/ButtonCommon" | |
| android:layout_width="match_parent" | |
| android:layout_height="wrap_content" | |
| android:text="TTS of all langauges" /> | |
| android:id="@+id/btnTtsLanguages" | |
| style="@style/ButtonCommon" | |
| android:layout_width="match_parent" | |
| android:layout_height="wrap_content" | |
| android:text="TTS of all languages" /> |
| style="@style/ButtonCommon" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:text="TTS of all langauges" /> |
There was a problem hiding this comment.
The button text contains a misspelling: "langauges" should be "languages".
Suggested change
| android:text="TTS of all langauges" /> | |
| android:text="TTS of all languages" /> |
| android:layout_width="match_parent" | ||
| android:layout_height="0dp" | ||
| android:layout_weight="1" | ||
| android:padding="16.dp"> |
There was a problem hiding this comment.
The padding value "16.dp" is incorrectly formatted. It should be "16dp" without the period.
Suggested change
| android:padding="16.dp"> | |
| android:padding="16dp"> |
| super.onCreate(savedInstanceState) | ||
| binding = ActivityTest137Binding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
|
|
There was a problem hiding this comment.
The back button (ibBack) defined in the layout is not configured with a click listener in this activity. Users will not be able to navigate back using this button.
Suggested change
| binding.ibBack.setOnClickListener { | |
| onBackPressedDispatcher.onBackPressed() | |
| } |
362780316
force-pushed
the
137_new_Feature_test
branch
2 times, most recently
from
47d3e3d to
1290bd2
Compare
362780316
force-pushed
the
137_new_Feature_test
branch
from
1290bd2 to
bd7803b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.