Reads gdocs and adds fault and falure codes to bugs #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To enable Docs API: https://developers.google.com/docs/api/quickstart/python Wasn't very comfortable with the message while authenticating: |
Contributor
Author
|
These file names have changed I guess in previous PRs: Also these bugs have not been assigned any codes: |
Contributor
Author
ChrisTimperley
requested changes
Nov 3, 2020
Member
ChrisTimperley
left a comment
ChrisTimperley
left a comment
There was a problem hiding this comment.
Awesome. This looks great. Just a few suggestions to improve the script. It would also help to add specific versions for the necessary dependencies to requirements.dev.txt.
hsd-dev
commented
Nov 3, 2020
Contributor
Author
|
On a side note: what is the distinction between requirements.dev.txt and requirements.txt? |
Contributor
Author
|
@ChrisTimperley please take a look now. |
| print(f"ERROR: Empty fields encountered for {row[COLUMN_BUG]} in 'ROBUST coding'") | ||
| yield [row[COLUMN_BUG], None, None] | ||
|
|
||
| def refactor_fault_failure(description: t.List[str], faults: t.List[str], failures: t.List[str], update: bool = True) -> None: |
Member
There was a problem hiding this comment.
faults and failures should be t.Optional[t.List[str]].
| yield [row[COLUMN_BUG], None, None] | ||
|
|
||
| def refactor_fault_failure(description: t.List[str], faults: t.List[str], failures: t.List[str], update: bool = True) -> None: | ||
| if 'failure-codes' and 'fault-codes' in description and not update: |
Member
There was a problem hiding this comment.
There need to be two separate in operations here (i.e., 'failure-codes' in description)
scripts/gdocs_reader.py
Outdated
| print(f"{err}") | ||
| return | ||
|
|
||
| faults_ = faults.upper().splitlines() if faults else faults |
Member
There was a problem hiding this comment.
faults_ has a type of t.Union[t.List[str], str] here. I think this should be:
fault_list: t.Optional[t.List[str]]
if not fault_cell:
fault_list = None
else:
fault_list = faults.upper().splitlines()
Member
There was a problem hiding this comment.
Unless faults can be None? In which case the type annotation for the method should be updated to faults: t.Optional[str].
Contributor
Author
There was a problem hiding this comment.
faults can be None because here:
yield [row[COLUMN_BUG], None, None]
Member
There was a problem hiding this comment.
Okay. Let's use an t.Optional[str] type.
Contributor
Author
|
@ChrisTimperley ping |
Contributor
Author
was not the intention, the rebase worked locally but didn't change anything after I pushed it. |
Contributor
Author
|
updated with #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.