Fix for creating square matrices and added identity property to the Matrix function#13
Open
MarkRedeman wants to merge 1 commit intorockbot:masterfrom
Open
Fix for creating square matrices and added identity property to the Matrix function#13MarkRedeman wants to merge 1 commit intorockbot:masterfrom
MarkRedeman wants to merge 1 commit intorockbot:masterfrom
Conversation
…atrix function The Matrix constructor used the (undefined) cols variable when creating the appropriate array instead of this.cols. There was a isIdentity parameter in the Matrix constructor but it wasn't used. I added the Matrix.identity(size).
Owner
|
Hi - thanks!! Please add some tests for your code - it'll not only make sure your code works the way you think it does, but it'll also help newcomers know how to use the functionality you've provided :-) Holler if you have questions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Matrix constructor used the (undefined) cols variable when creating the appropriate array instead of this.cols.
There was a isIdentity parameter in the Matrix constructor but it wasn't used. I added the Matrix.identity(size).