Do not introduce recursive rtrees for non-recursive nesting inductive types#21600
Open
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Open
Do not introduce recursive rtrees for non-recursive nesting inductive types#21600ppedrot wants to merge 1 commit intorocq-prover:masterfrom
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Conversation
… types.
The previous code was representing every nested inductive node as an rtree
of the form µX.F{X}. For nesting types that were not recursive this was
inefficient, as the variable X cannot appear in the body F of the rtree,
leading to useless rtree expansions in fixpoint computation. This commit
basically compiles this node as F with the above notation.
ppedrot
added
kind: performance
coqbot-app
bot
removed
the
request: full CI
Member
Author
|
@coqbot bench |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was representing every nested inductive node as an rtree of the form µX.F{X}. For nesting types that were not recursive this was inefficient, as the variable X cannot appear in the body F of the rtree, leading to useless rtree expansions in fixpoint computation. This commit basically compiles this node as F with the above notation.
This is still much less efficient than keeping an indirect representation for composed rtrees, but still better than nothing.