Skip to content

Fixing grammar of the introductory ssreflect documentation.#21602

Open
jstrattonsmith wants to merge 1 commit intorocq-prover:masterfrom
jstrattonsmith:ssreflect-docs-typo-1
Open

Fixing grammar of the introductory ssreflect documentation.#21602
jstrattonsmith wants to merge 1 commit intorocq-prover:masterfrom
jstrattonsmith:ssreflect-docs-typo-1

Conversation

@jstrattonsmith
Copy link

Fixes confusing language in the ssreflect manual, making it easier for new users to understand.

Documentation update only.

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

@jstrattonsmith jstrattonsmith requested a review from a team as a code owner February 6, 2026 22:34
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 6, 2026
Copy link
Member

@jfehrle jfehrle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestions. The word choice in the original was not very conventional.

I'm not an expert on SSR. My impression is that there are better resources for learning SSR.

@@ -1046,7 +1046,7 @@ constants to the goal.
move=> m n le_n_m.

where ``move`` does nothing, but ``=> m n le_m_n`` changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where ``move`` does nothing, but ``=> m n le_m_n`` changes
where ``move`` does nothing, but ``=> m n le_m_n`` introduces

Comment on lines +1049 to 1051
the variables and assumption of the goal into the constants
``m n : nat`` and the fact ``le_n_m : n <= m``, thus exposing the
conclusion ``m - n + n = m``.
Copy link
Member

@jfehrle jfehrle Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the variables and assumption of the goal into the constants
``m n : nat`` and the fact ``le_n_m : n <= m``, thus exposing the
conclusion ``m - n + n = m``.
the variables ``m`` and ``n`` and the hypothesis
``le_n_m : n <= m``, giving the new goal ``m - n + n = m``.

FWIW this is equivalent to the intros tactic, which isn't part of SSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants