Skip to content

Connection creation closes #19 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrickWalker wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Connection creation closes #19 #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10d2ca7
psuedo connection check
Aug 14, 2019
fc668f1
eslint fixes
Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/connectionHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ const connectionHandler = async (connection) => {

if ((typeof connection === 'object') && (!(connection instanceof Connection) && !(connection instanceof Pool))) {
debug('creating connection from object:', connection);
if (connection.isPool) {
if (connection.config) {
connection = mysql.createConnection(connection.config);
} else if (connection.isPool) {
connection = mysql.createPool(connection);
} else {
connection = mysql.createConnection(connection);
Expand Down