Prevent infinite recursion in filter match with depth limit #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matchfunction inTxtaiStore._matches_filtersrecursively processes nested collections but lacked depth protection, risking stack overflow with deeply nested or circular structures.Changes:
depthparameter tomatchfunction with_FILTER_MATCH_MAX_DEPTH = 10class constantFalsewith warning log when depth limit exceededNormal filter operations unaffected; only prevents pathological cases beyond 10 nesting levels.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.