Open
Conversation
This feature is in response to rojer#18. The feature allows the user to select a Drive folder from the dropdown and check the "Remember this folder" box. Next time when the user takes a screenshot, this folder (and it's children) will be loaded in the dropdown. A localStorage key was added to store these settings.
Using the HTML5 Download API and a plain old, <a> tag, the Save to computer feature works with or without Flash enabled. This is in response to rojer#13.
Updated the name of the downloaded image to be the name of the tab it came from.
This reverts commit 78cd891.
This reverts commit 3081b50.
This reverts commit aa41b97.
Restoring repo to same state as roger/a-s-minus
When in editing view, the keyboard shortcuts are needed; these shortcuts are binded on the initial load of the editing view, and any subsequent "re-edits". The shortcuts are unbinded once the save view is loaded, so that the user can hit keys without unintended behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #23. When the "save view" is loaded (the screen where the user selects where they want to save the screenshot), the keyboard shortcuts are unbinded; this way, the user can change the name of their screenshot (or otherwise hit keys on the keyboard) and not edit the image. When the "editing view" is loaded (the screen where the user edits the screenshot), the shortcuts are rebinded so that they work as intended.
This appears to be work fine for me and doesn't appear to have broken any other features. Please check before merging however; you probably know this extension better than me.