-
Notifications
You must be signed in to change notification settings - Fork 14
Ht3 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
algv
wants to merge
2
commits into
romabelka:master
Choose a base branch
from
algv:HT3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ht3 #17
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
| import firebase from 'firebase' | ||
|
|
||
| export const appName = 'advreact-1610' | ||
| const appId = 'ec352' | ||
|
|
||
| firebase.initializeApp({ | ||
| apiKey: "AIzaSyB31xpTtp4Jln_hb2kAbE4PGf6Mi8EgLyA", | ||
| authDomain: `${appName}.firebaseapp.com`, | ||
| databaseURL: `https://${appName}.firebaseio.com`, | ||
| projectId: appName, | ||
| storageBucket: "", | ||
| messagingSenderId: "397157634637" | ||
| }) | ||
| apiKey: "AIzaSyB3LVTO7RSDrZAkHBkpzg9T5KkuoCoy4qo", | ||
| authDomain: `${appName}-${appId}.firebaseapp.com`, | ||
| databaseURL: `https://${appName}-${appId}.firebaseio.com`, | ||
| projectId: `${appName}-${appId}`, | ||
| storageBucket: `${appName}-${appId}.appspot.com`, | ||
| messagingSenderId: "651090769196" | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import {all, takeEvery, put, call} from 'redux-saga/effects' | ||
| import {all, put, call, takeEvery} from 'redux-saga/effects' | ||
| import {appName} from '../config' | ||
| import {Record, OrderedMap, OrderedSet} from 'immutable' | ||
| import firebase from 'firebase' | ||
|
|
@@ -14,6 +14,9 @@ const prefix = `${appName}/${moduleName}` | |
| export const FETCH_ALL_REQUEST = `${prefix}/FETCH_ALL_REQUEST` | ||
| export const FETCH_ALL_START = `${prefix}/FETCH_ALL_START` | ||
| export const FETCH_ALL_SUCCESS = `${prefix}/FETCH_ALL_SUCCESS` | ||
| export const FETCH_LAZY_REQUEST = `${prefix}/FETCH_LAZY_REQUEST` | ||
| export const FETCH_LAZY_START = `${prefix}/FETCH_LAZY_START` | ||
| export const FETCH_LAZY_SUCCESS = `${prefix}/FETCH_LAZY_SUCCESS` | ||
|
|
||
| export const SELECT_EVENT = `${prefix}/SELECT_EVENT` | ||
|
|
||
|
|
@@ -43,9 +46,11 @@ export default function reducer(state = new ReducerRecord(), action) { | |
|
|
||
| switch (type) { | ||
| case FETCH_ALL_START: | ||
| case FETCH_LAZY_START: | ||
| return state.set('loading', true) | ||
|
|
||
| case FETCH_ALL_SUCCESS: | ||
| case FETCH_LAZY_SUCCESS: | ||
| return state | ||
| .set('loading', false) | ||
| .set('loaded', true) | ||
|
|
@@ -83,6 +88,12 @@ export function fetchAllEvents() { | |
| } | ||
| } | ||
|
|
||
| export function fetchLazyEvents() { | ||
| return { | ||
| type: FETCH_LAZY_REQUEST | ||
| } | ||
| } | ||
|
|
||
| export function selectEvent(uid) { | ||
| return { | ||
| type: SELECT_EVENT, | ||
|
|
@@ -109,16 +120,28 @@ export function* fetchAllSaga() { | |
| }) | ||
| } | ||
|
|
||
| //lazy fetch FB | ||
| /* | ||
| firebase.database().ref('events') | ||
| .orderByKey() | ||
| .limitToFirst(10) | ||
| .startAt(lastUid) | ||
| export function* fetchLazySaga() { | ||
| yield put({ | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ты нигде не проверяешь, а вдруг ты уже грузишь сейчас эти данные |
||
| type: FETCH_LAZY_START | ||
| }) | ||
|
|
||
| const lastUid = stateSelector.entities ? stateSelector.entities.last().uid : '' | ||
|
|
||
| const ref = firebase.database().ref('events') | ||
| .orderByKey() | ||
| .limitToFirst(10) | ||
| .startAt(lastUid) | ||
|
|
||
| const snapshot = yield call([ref, ref.once], 'value') | ||
|
|
||
| yield put({ | ||
| type: FETCH_LAZY_SUCCESS, | ||
| payload: snapshot.val() | ||
| }) | ||
| } | ||
|
|
||
| */ | ||
| export function* saga() { | ||
| yield all([ | ||
| takeEvery(FETCH_ALL_REQUEST, fetchAllSaga) | ||
| takeEvery(FETCH_LAZY_REQUEST, fetchLazySaga) | ||
| ]) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше так не делать - будет постоянно сбиваться скролл(Table будет пересоздаваться вместо обновления)