hw5 #28
Open
hw5 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romabelka
reviewed
Sep 18, 2017
| const auth = firebase.auth() | ||
| const callback = (user) => emmit({user}) | ||
| auth.onAuthStateChanged(callback) | ||
| return () => {} |
Owner
There was a problem hiding this comment.
зачем ты возвращаешь пустую функцию? Такое тебя в результате приведет к неприятным багам. auth.onAuthStateChanged возвращает нужный колбек
| let task | ||
| while (true) { | ||
| const action = yield take(SIGN_IN_REQUEST) | ||
| const {payload} = yield take(SIGN_IN_REQUEST) |
Owner
There was a problem hiding this comment.
не очень понял, что тего ты хочешь достичь
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hw5