Fix for negative Unix timestamps on Windows#77
Open
gezmisozkan wants to merge 3 commits intorongardF:mainfrom
Open
Fix for negative Unix timestamps on Windows#77gezmisozkan wants to merge 3 commits intorongardF:mainfrom
gezmisozkan wants to merge 3 commits intorongardF:mainfrom
Conversation
…stamps on Windows and restore full historical XAUUSD data.
- Add TvDatafeed.get_quotes(symbols, timeout) using TradingView Quote Session (qsd parsing) - Reuse one WebSocket connection for many symbols; handle timeouts and invalid symbols - Ensure websocket cleanup (try/finally) and close connections after get_hist - Add benchmark_realtime.py and document get_quotes + benchmark in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found an issue in timestamp parsing on Windows. When fetching symbols
with very old history (e.g. XAUUSD on OANDA), TradingView returns negative
Unix timestamps for pre-1970 data. datetime.fromtimestamp raises OSError on
Windows for negative values, causing get_hist to fail.
Replacing fromtimestamp with an epoch + timedelta(seconds) calculation fixes
the problem and works consistently across Windows, Linux, and macOS. I can
submit a PR if you’d like.