Skip to content

added intellij-codestyle.xml and applying it to all java code#1

Open
ronreynolds wants to merge 6 commits intomasterfrom
intellij-style-xml
Open

added intellij-codestyle.xml and applying it to all java code#1
ronreynolds wants to merge 6 commits intomasterfrom
intellij-style-xml

Conversation

@ronreynolds
Copy link
Owner

@ronreynolds ronreynolds commented Feb 20, 2025

applying code-style via IntelliJ to make java code consistent and thus easier to read; ABSOLUTELY NO functional changes; just cleaner code.

includes intellij-codestyle.xml so that other IntelliJ users can import it as the project-level style.

applied to a handful of java classes to show the fairly minimal changes it would cause (all of which seemed reasonable to me).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ronreynolds ronreynolds self-assigned this Feb 20, 2025
@ronreynolds ronreynolds changed the title added intellij-codestyle.xml and sample of it being applied to some classes added intellij-codestyle.xml and applying it to all java code Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant