Update module to reflect API changes plus provide more comments and pythonic classes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- API_KEY instead of APP_ID and APP_SECRET - clean Resources sub-classes - fix Gadgets - extra comments - Person object
- test_gadgets is now a unittest class - combined listing gadgets and generating a quote for them into single "GadgetsCover" class - made Quotes more OOP for easier subclassing of different modules - Policyholder class as an application of class for type and some validation in python - Resources' call has defaults for sub-classes which can be overridden at call! - main.py has a 'full' process example for gadgets
ubmodule so imports are all through 'root.insurance'
Contributor
|
+1 from me. Looks good. |
Contributor
|
Interesting. Abstracting this thing so that when the other APIs come online, we can just add to this repo rather than create new ones? |
|
|
||
| def test_list_models(self): | ||
| result = self.client.quotes.list_models() | ||
| assert result |
There was a problem hiding this comment.
Thoughts on using the unittest module's assertion tools? They tend to be better (IMO) and provide much better error reports when tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
example.pyfor how to use the module.Changes made should make the use of the module more intuitive and explanatory.