Copied Timer.h from VecCore, so it doesn't depend on VecCore for it.#7
Open
mrguilima wants to merge 1 commit intoroot-project:masterfrom
Open
Copied Timer.h from VecCore, so it doesn't depend on VecCore for it.#7mrguilima wants to merge 1 commit intoroot-project:masterfrom
mrguilima wants to merge 1 commit intoroot-project:masterfrom
Conversation
Member
|
@amadio Is this the best solution? |
Member
|
That file was meant to be private to VecCore, as it's only used in tests. If you want to copy it, I recommend copying the latest version, since it is more portable (now works also on Windows). |
Member
|
@mrguilima ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After tag 0.5.2, VecCore has renamed VecCore/Timer.h to VecCore/timer.h, and this file is not being installed anymore, which VecMath depends on.
So I copied VecCore/Timer.h into test/RngTest/inc/ directory, and adapted the old #include's accordingly.