Conversation
Client ID Registration
Remove unneeded test
Client ID registration: Email Setup
* Update readme url for client id reg * Update the email set for client id registration to api@ror.org
…-all-fix Add fix for ror-roadmap/issues/310
…k-ror-id-fix Fixes and tests for ror-roadmap/issues/307 and ror-roadmap/issues/308
jrhoads
requested review from
adambuttrick,
ashwinisukale,
kaysiz and
mariagould
adambuttrick
approved these changes
Jun 17, 2025
kaysiz
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes work that addresses several bug fixes from
ror-community/ror-roadmap#307
ror-community/ror-roadmap#308
ror-community/ror-roadmap#310
It also includes the commit history from the ClientID work. So may look a little gnarly. If you look at the file level diff, you can see the only changes are from the bug-fixes
https://github.com/ror-community/ror-api/compare/master..staging