Skip to content

Comments

Remove Schema v1 support and migrate indexing workflows to v2#229

Merged
jrhoads merged 1 commit intomainfrom
v2-data-indexing
Feb 11, 2026
Merged

Remove Schema v1 support and migrate indexing workflows to v2#229
jrhoads merged 1 commit intomainfrom
v2-data-indexing

Conversation

@jrhoads
Copy link
Member

@jrhoads jrhoads commented Feb 11, 2026

Purpose

The purpose of this PR is to remove support for Schema version 1 (v1) from the manual indexing and dump indexing GitHub workflows, effectively migrating all indexing processes to Schema version 2 (v2).

Approach

The changes simplify the CI/CD pipelines by removing conditional logic that handled both v1 and v2 schemas. The workflows now default to and exclusively use v2 endpoints and validation rules.

Key Modifications

  • Workflow Inputs: Removed v1 from the schema-version choice options across all indexing workflows.
  • Example Text: Updated the release-dump description to show a v2 example date (v2.0-2025-12-16-ror-data).
  • Logic Removal:
    • Removed if/else blocks in prod_index_dump.yml, prod_manual_index.yml, staging_index_dump.yml, and staging_manual_index.yml that branched based on schema version.
    • Standardized API URL usage to the _V2 secrets.
  • Validation Update: Updated the validation step in staging_manual_index.yml to exclusively use the ROR Schema v2.1 JSON and run validations with the -v 2 flag.

Important Technical Details

  • The workflows now point directly to INDEX_DUMP_PROD_API_URL_V2, INDEX_PROD_API_URL_V2, and their staging equivalents.
  • Directory naming conventions for indexing have been standardized to use the -v2 suffix.
  • The staging_manual_index.yml now fetches the schema from the schema-v2-1 branch of the ror-schema repository.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads merged commit a4545c6 into main Feb 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants