[WIP] Adds support for passing in a name and a Flask application to the ini…#82
Open
palnabarun wants to merge 3 commits intororodata:masterfrom
Open
[WIP] Adds support for passing in a name and a Flask application to the ini…#82palnabarun wants to merge 3 commits intororodata:masterfrom
palnabarun wants to merge 3 commits intororodata:masterfrom
Conversation
anandology
reviewed
Oct 12, 2018
firefly/app.py
Outdated
|
|
||
| class Firefly(object): | ||
| def __init__(self, auth_token=None, allowed_origins=""): | ||
| def __init__(self, name, auth_token=None, allowed_origins="", flask_app=None): |
Member
There was a problem hiding this comment.
use name=None and set it to "firefly" if not specified. That way you don't have to change any of the existing code.
Member
|
Looks like you haven't added flask to |
Contributor
Author
|
Yes. I didn't. I am still working on this PR. |
| self.auth_token = auth_token | ||
| self.allowed_origins = allowed_origins | ||
|
|
||
| self.flask_app = flask_app or Flask(name) |
There was a problem hiding this comment.
Ideally it should be,
self.flask_app = flask_app if flask_app else Flask(name) as this is more readable.
The current statement also evaluates to the same result, however intent is not clear, and one has to know that Python evaluates or lazily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t of Firefly