Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the API of the EventProcessor class:
The eventExtTrigger() method now expects a return value. When returning false, a currently in-progress call to decode() or decodeUntil() is terminated, and must be resumed by calling decode() or decodeUntil() again on the same message buffer to evolve the state of the decoder correctly.
This change to the API was necessary to facilitate terminating the decoding process when a trigger event is received. Without this change to the API, there is no way to interrupt and resume the decoding process.
I also considered switching to an iterator-based design altogether, but that could cut into the performance, because in the case of vector events, the iterator has to remember not just which byte it is processing, but also which bit.