fix for incorrect timestamps for imu and frame msgs#13
Merged
berndpfrommer merged 3 commits intoros-event-camera:masterfrom Nov 20, 2025
Merged
fix for incorrect timestamps for imu and frame msgs#13berndpfrommer merged 3 commits intoros-event-camera:masterfrom
berndpfrommer merged 3 commits intoros-event-camera:masterfrom
Conversation
Instead of passing current rostime to the frame and imu Callbacks, now correctly pass rosBaseTime_ (rostime at startup) to both. Then the sensor_time of the SDK_packet is added, resulting in the time visible in the msgs. note: the change to the frame callback is technically not tested, because the hardware accessible to me does not support frame capture. Signed-of-by: Erik Schlenzka
Signed-off-by: Erik Schlenzka
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linked to this issue: #12
Instead of passing current rostime to the frame and imu Callbacks,
now correctly pass rosBaseTime_ (rostime at startup) to both.
Then the sensor_time of the SDK_packet is added, resulting in the time visible
in the msgs.
note:
the change to the frame callback is technically not tested, because
the hardware accessible to me does not support frame capture.
IMU times where tested on dvxplorer and dvxplorer-micro.