Skip to content

Generation of copyright files#709

Open
ct2034 wants to merge 7 commits intoros-infrastructure:masterfrom
ct2034:add/copyright_file_generation
Open

Generation of copyright files#709
ct2034 wants to merge 7 commits intoros-infrastructure:masterfrom
ct2034:add/copyright_file_generation

Conversation

@ct2034
Copy link

@ct2034 ct2034 commented Sep 27, 2023

Implementation of #697.
Generates copyright file complying with https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
It uses https://github.com/boschresearch/ros_license_toolkit as a dependency. I would be happy to move that to this org, too.

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 marked this pull request as ready for review October 31, 2023 12:24
@ct2034
Copy link
Author

ct2034 commented Jan 15, 2025

At ROSCon I talked to @nuclearsandwich and @clalancette. This is my summary what we agreed to do:
Yes, the REP change was accepted in the TSC.
I would like to merge this integrating ros_license_linter.
But there are problems because:
a) This must increment the package.xml schema version.
b) @clalancette wants to do other changes then, too.
So, the solution was to change the tooling such that it
a) differentiates between package.xml versions (not requiring the new attributes introduced by REP change),
b) And it never cause bloom to fail.
These changes are now implemented on our side.

@ct2034
Copy link
Author

ct2034 commented Mar 3, 2025

As an update: We think, we can get rid of the dependency on spdx-tools (https://github.com/boschresearch/ros_license_toolkit/blob/63c7406866a5f81eee1457922a6b17fb6b0fd2df/pyproject.toml#L31) but we will probably have to keep the dependency on scancode-toolkit. What are the next steps, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants