Conversation
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Use a wrapper function to make the em.expand calls. Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
tfoote
approved these changes
Jan 23, 2026
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
This is the same approach as osrf/rocker#261
cottsay
requested changes
Feb 6, 2026
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
Can we start with a PR just to get EmPy v3/v4 support, and make the other improvements in a follow-up PR?
Co-authored-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
cottsay
reviewed
Feb 9, 2026
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
This is a lot cleaner, thanks. Just one more comment.
Co-authored-by: Scott K Logan <logans@cottsay.net>
Removed 'setuptools' and 'empy < 4' from install_requires.
This reverts commit 6f6a571.
cottsay
reviewed
Feb 10, 2026
cottsay
reviewed
Feb 10, 2026
cottsay
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR change the code to support empy 4.x versions together with keeping support for empy3.
Per commit changes are:
The test code won't evolve automatically over the time when new Python versions appear but we can consider it something temporal until we deprecate empy3 completely.