Do not install ccache unless shared_ccache is used in binarydeb #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the sharing of compilation artifacts through ccache is not being done unless the shared_ccache is in use. The ccache binaries are currently being installed unconditionally. The PR changes the behaviour to install the ccache only when the shared_ccache option is being used. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
tfoote
reviewed
Feb 6, 2024
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
This generally looks good. One nit about the import ordering.
| import sys | ||
|
|
||
| from ros_buildfarm.argument import add_argument_append_timestamp | ||
| from ros_buildfarm.argument import add_argument_append_timestamp, add_argument_install_ccache |
Member
There was a problem hiding this comment.
We're doing one per line for all the others. We should do that here too
| import sys | ||
|
|
||
| from ros_buildfarm.argument import add_argument_append_timestamp | ||
| from ros_buildfarm.argument import add_argument_append_timestamp, add_argument_install_ccache |
Member
There was a problem hiding this comment.
We're doing one per line for all the others. We should do that here too. Note that will move it down to keep in alphabetical order.
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sharing of compilation artifacts through ccache is conditional after #844, which enable the support for sharing with the host using the
shared_ccacheoption in the build files. The ccache binaries are currently being installed unconditionally thought.The PR changes the behavior to install the ccache binaries only when the
shared_ccacheoption is being used.