Conversation
This sub-package presents vcs2l as a wholesale replacement for vcstool and should satisfy any existing dependencies on vcstool without requiring changes to vcs2l itself. It operates under the fact that the existing vcs2l API is similar enough to vcstool that it can simply be installed and used under that name. When the vcs2l API deviates from vcstool enough, this commit may be reverted and the shim package dropped. Signed-off-by: Scott K Logan <logans@cottsay.net>
55779bd to
a82ddeb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 26.96% 26.96%
=======================================
Files 31 31
Lines 2240 2240
Branches 393 393
=======================================
Hits 604 604
Misses 1576 1576
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Comparing to what we did in gazebo-release/gz_math_vendor#18 and we are generalizing in gazebo-tooling/gz_vendor#26. seems to me a different approach:
I think that use cases are quite different. Here there is a transparent aliasing for vcs command invocations. most of them hosted in bin/. In gz_*_vendor we are dealing with a Python library so we mostly prepare the terrain for the usuals "import gz_foo" or "from gz_foo import lala". A single entry point coming from a Python import. Said that: I think that both approaches are fine taking into account the different context on both packages (one is a vendoring, another is a native) |
Basic Info
Description of contribution in a few bullet points
This sub-package presents vcs2l as a wholesale replacement for vcstool and should satisfy any existing dependencies on vcstool without requiring changes to vcs2l itself. It operates under the fact that the existing vcs2l API is similar enough to vcstool that it can simply be installed and used under that name.
When the vcs2l API deviates from vcstool enough, this commit may be reverted and the shim package dropped.
Description of how this change was tested
pre-commit run --allpython3 -m pytest -s -v testpython3-vcstool