Update usage of spin_until_future_complete#556
Closed
hliberacki wants to merge 1 commit intoros2:rollingfrom
Closed
Update usage of spin_until_future_complete#556hliberacki wants to merge 1 commit intoros2:rollingfrom
spin_until_future_complete#556hliberacki wants to merge 1 commit intoros2:rollingfrom
Conversation
Author
|
Due to changes in RCLCPP, made in ros2/rclcpp#1874 PR. |
audrow
approved these changes
Mar 30, 2022
Member
audrow
left a comment
audrow
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Member
|
fujitatomoya
approved these changes
Apr 1, 2022
Author
|
@audrow ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
…mplete` Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
7a56ad2 to
f880a52
Compare
SteveMacenski
approved these changes
Jun 24, 2022
Member
|
I've opened #669 to replace this PR. |
Member
|
This can be closed, see #669 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
spin_until_completeinstead of deprecatedspin_until_future_completeSigned-off-by: Hubert Liberacki hliberacki@gmail.com