Add section on uniquely identifier interface definitions#220
Add section on uniquely identifier interface definitions#220jacobperron wants to merge 9 commits intogh-pagesfrom
Conversation
|
Can we do better than relying on file system layout to uniquely identify a message? What about using package name and a hash generated from the comment-less version of the message definition? |
That doesn't seem practical if the user has to specify a message type on the command line. |
True. I was thinking only in terms of automated tools, but the usability aspect for the user/programmer is probably more important. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Reference the IDL section on identifying interfaces and be explicit about the namespaces for messages, services, and actions. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
11564de to
729c2d9
Compare
|
After an offline discussion, I've updated this PR attempting to address the problem of identifying interfaces in general (pure IDL). |
dirk-thomas
left a comment
There was a problem hiding this comment.
Considering a command line tool like ros2 msg I would expect it to take a URN as an argument. The problem I see is that it doesn't know what the correct URL is in order to import the module containing the type.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Is it possible for typesupport to provide the URL? I.e. provide a mapping from a types URN to the URL. |
Maybe that information could be put into the resource index. Currently each URN has a marker file in the resource index. Instead of using an empty file it could contain the URL. |
That might work. But is it the case that there is a marker file for each URN? It looks like there is a single marker file for the package containing relative paths to the resource files (not necessarily URNs). For example, there's a file content |
* Use URI, instead of URN, for interface definitions * Add forward slashes to URL and rename 'rosidl' -> 'package' Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Follow up from ros2/rmw_opensplice#263 (comment)
This is a proposal for uniquely identifying ROS interfaces that does not make any assumptions about the subfolder(s) where the interface definitions are found.