Skip to content

Explicitly add DLL directories for Windows before importing #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 2 commits into from
May 18, 2020
Merged

Explicitly add DLL directories for Windows before importing #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35af0a
Explicitly add DLL directories for Windows before importing
jacobperron May 16, 2020
6f7c56a
Apply similar change to test
jacobperron May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tf2_py/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rclpy</exec_depend>
<exec_depend>rpyutils</exec_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_cmake_pytest</test_depend>
Expand Down
11 changes: 8 additions & 3 deletions tf2_py/test/test_buffer_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@

from geometry_msgs.msg import TransformStamped
import rclpy

from test_tf2_py._tf2_py import BufferCore
from test_tf2_py._tf2_py import LookupException
from rpyutils import add_dll_directories_from_env

# Since Python 3.8, on Windows we should ensure DLL directories are explicitly added
# to the search path.
# See https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew
with add_dll_directories_from_env('PATH'):
from test_tf2_py._tf2_py import BufferCore
from test_tf2_py._tf2_py import LookupException


def build_transform(target_frame, source_frame, stamp):
Expand Down
8 changes: 7 additions & 1 deletion tf2_py/tf2_py/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,10 @@
#
# Author: Eitan Marder-Eppstein
# **********************************************************
from tf2_py._tf2_py import * # noqa
from rpyutils import add_dll_directories_from_env

# Since Python 3.8, on Windows we should ensure DLL directories are explicitly added
# to the search path.
# See https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew
with add_dll_directories_from_env('PATH'):
from tf2_py._tf2_py import * # noqa