Skip to content

Use get_type_hash_func on typesupports (rep2011)#1053

Merged
clalancette merged 1 commit intoros2:masterfrom
emersonknapp:emersonknapp/get-type-hash-function
Apr 6, 2023
Merged

Use get_type_hash_func on typesupports (rep2011)#1053
clalancette merged 1 commit intoros2:masterfrom
emersonknapp:emersonknapp/get-type-hash-function

Conversation

@emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Apr 4, 2023

Part of ros2/ros2#1159
Depends on ros2/rosidl#727 (and is bundled with)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp changed the title [WIP] Use get_type_hash_func for typesupports (rep2011) [WIP] Use get_type_hash_func on typesupports (rep2011) Apr 4, 2023
@emersonknapp emersonknapp changed the title [WIP] Use get_type_hash_func on typesupports (rep2011) Use get_type_hash_func on typesupports (rep2011) Apr 4, 2023
@emersonknapp emersonknapp marked this pull request as ready for review April 4, 2023 16:31
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/3d42343216f83e16ec6b739829a33a15/raw/710780b6ce1a1318b21363581bad84a247f92bb4/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11795

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit bb46ee6 into ros2:master Apr 6, 2023
@christophebedard
Copy link
Member

christophebedard commented Apr 6, 2023

@clalancette FYI this was merged into master instead of rolling. This change isn't available in Rolling, so source builds are failing.

cc @emersonknapp

@mergify
Copy link

mergify bot commented Apr 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #1055. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants