Add ~/get_type_description service (rep2011) (dupe of #1052)#1059
Add ~/get_type_description service (rep2011) (dupe of #1052)#1059james-rms wants to merge 17 commits intoros2:rollingfrom
Conversation
james-rms
force-pushed
the
jrms/rep2011_get_type_description_srv
branch
from
388dd40 to
bf20c9d
Compare
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
…interfaces structs Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com> Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/rep2011_get_type_description_srv
branch
from
bf20c9d to
baf3d15
Compare
|
Gist: https://gist.githubusercontent.com/james-rms/e1c0c45c7e56d86cb09c5bbc28aa5f72/raw/ef08db1b38130acc2c1b27715c98cf640f14e24c/ros2.repos
|
|
Instead of a completely new PR, can we just open a PR to that PR? It will keep all of the history intact. |
This would then be a new PR on top of #1052 with a single merge commit? |
In general, we like to keep all development of a branch in one PR. If we need to rebase #1052, then please feel free to do that. If we need to add new PRs on top of #1052 , then please just push them there. And then close this PR. The only reasons to open a new PR is if we want to split some work out, or if the original author is not responding and we can't push to their fork anymore for some reason. |
|
OK, I have rebased #1052 so I believe we can close this PR |
OK, sounds good. Will close this one out. @james-rms If we need this one for some reason, please feel free to reopen. |
3 participants
Dupe of #1052 , rebased to fix a test.