Improved documentation of rcl_XYZ_set_on_new_XYZ_callback #1289
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed off: Rushhaank Sahay rushhaank.sahay@gmail.com
Updates the documentation for rcl_service_set_on_new_request_callback and rcl_subscription_set_on_new_message_callback methods to encourage users to make the process non-blocking and warn them of unexpected behavior if it is blocked
Fixes #1282
Addresses #1277
Is this user-facing behavior change?
Yes. It changes user behavior as it specifies to users the proper way to use these methods to avoid unexpected behaviors.
Did you use Generative AI?
No