content filtered topic for action feedback subscription#901
Open
iuhilnehc-ynos wants to merge 20 commits intoros2:rollingfrom
Open
content filtered topic for action feedback subscription#901iuhilnehc-ynos wants to merge 20 commits intoros2:rollingfrom
iuhilnehc-ynos wants to merge 20 commits intoros2:rollingfrom
Conversation
15 tasks
Comment on lines
+748
to
+754
| feedback_filter_update = | ||
| rcutils_format_string(allocator, "goal_id.uuid = &hex(%s)", uuid_str); |
Collaborator
There was a problem hiding this comment.
just checking, i wasn't clear before but this hex is not in the spec for interoperability? Annex B - Syntax for Queries and Filters?
Collaborator
Author
There was a problem hiding this comment.
Yes, it's not the official spec.
Collaborator
Author
Yes, based on #894 not reviewed, I think we can combine the part1(Just CFT interfaces) and part2(CFT for parameter_event and action feedback topics). Do you think the #894 can be closed? |
Collaborator
yeah, i guess so 😄 |
iuhilnehc-ynos
force-pushed
the
topic-content_filtered_topic-action
branch
from
0d6a26d to
34d0802
Compare
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
force-pushed
the
topic-content_filtered_topic-action
branch
from
34d0802 to
2f955bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to ros2/design#282
action
feedbackenhancement