Conversation
ihasdapie
force-pushed
the
service_introspection
branch
from
136b620 to
34fb02d
Compare
ivanpauno
reviewed
Aug 8, 2022
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
do you already have a PR for generating the new messages for each service?
ihasdapie
force-pushed
the
service_introspection
branch
from
34fb02d to
ba74ac1
Compare
This was referenced Aug 9, 2022
jacobperron
reviewed
Aug 16, 2022
jacobperron
reviewed
Aug 16, 2022
ihasdapie
force-pushed
the
service_introspection
branch
from
ba74ac1 to
8c871b5
Compare
jacobperron
reviewed
Sep 29, 2022
jacobperron
force-pushed
the
service_introspection
branch
from
8c871b5 to
39827df
Compare
Member
|
rebased on rolling |
ivanpauno
approved these changes
Nov 10, 2022
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM, we should double check if using unique_identifier_msgs/UUID is fine or not before merging
ivanpauno
force-pushed
the
service_introspection
branch
from
eae4004 to
d0c3096
Compare
Member
|
Rebased and added d0c3096, if not |
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add useful links to info about services and REP 2012 * Minor refactoring Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Minor wording changes * Remove/replace dead links Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add stricter compile options * Add comment describing why we use 'core' generators instead of 'default' Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Technically, it is not a dependency. Only a dependency on actual action interfaces being generated. This dependency should probably be exported by rosidl_defaults Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
That is, this field should be a GID, not a UUID (even though they happen to be the same length). Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
service_introspection
branch
from
d0c3096 to
b8d7674
Compare
gbiggs
approved these changes
Jan 26, 2023
mjcarroll
approved these changes
Jan 31, 2023
Contributor
|
CI for this is in ros2/ros2#1285 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prototype for the service introspection REP (ros-infrastructure/rep#360) adding a
service_msgspackage implementing the proposed embedded message approach (ros-infrastructure/rep#360 (comment)).For instructions on how to build and run this see the meta-ticket ros2/ros2#1285.