Feature: add logger_name property to subscription, publisher, service and client by nadavelkabets · Pull Request #1471 · ros2/rclpy

nadavelkabets · 2025-06-21T10:35:51Z

Part of #1399.
According to the documentation of rcl_node_get_logger_name the value of the string may change, so I think it's best to fetch the most recent string when getting the logger_name property.

Signed-off-by: Nadav Elkabets <elnadav12@gmail.com>

fujitatomoya

lgtm with green CI.

fujitatomoya · 2025-06-23T23:20:11Z

@ahcorde can you do the 2nd review for this?

fujitatomoya · 2025-06-23T23:20:57Z

Pulls: #1471
Gist: https://gist.githubusercontent.com/fujitatomoya/fee4f0705fa1e95ab88c19f55a011201/raw/cc953952d8af6bc65c599a330a13bb00c7a4b7ee/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16288

Linux
Linux-aarch64
Linux-rhel
Windows

rclpy/src/rclpy/service.cpp

rclpy/test/test_publisher.py

Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

ahcorde · 2025-06-24T07:03:41Z

Linux
Linux-aarch64
Linux-rhel
Windows

ahcorde · 2025-06-24T14:07:05Z

should we backport this PR to other distros ?

nadavelkabets · 2025-06-24T14:41:00Z

should we backport this PR to other distros ?

This feature is part of the AsyncioExecutor PR.
I would like to backport the AsyncioExecutor to Jazzy, so I think we should backport this to jazzy as well.
What do you think?

ahcorde · 2025-06-24T14:45:12Z

https://github.com/Mergifyio backport kilted jazzy humble

mergify · 2025-06-24T14:45:28Z

backport kilted jazzy humble

✅ Backports have been created

Details

#1474 Feature: add logger_name property to subscription, publisher, service and client (backport #1471) has been created for branch kilted
#1475 Feature: add logger_name property to subscription, publisher, service and client (backport #1471) has been created for branch jazzy but encountered conflicts
#1476 Feature: add logger_name property to subscription, publisher, service and client (backport #1471) has been created for branch humble but encountered conflicts

… and client (#1471) Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 4859c8a)

… and client (#1471) Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 4859c8a) # Conflicts: # rclpy/rclpy/client.py # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/publisher.py # rclpy/rclpy/service.py # rclpy/rclpy/subscription.py # rclpy/test/test_client.py

… and client (#1471) Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 4859c8a) # Conflicts: # rclpy/rclpy/client.py # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/publisher.py # rclpy/rclpy/service.py # rclpy/rclpy/subscription.py # rclpy/src/rclpy/client.cpp # rclpy/src/rclpy/client.hpp # rclpy/src/rclpy/service.cpp # rclpy/test/test_client.py # rclpy/test/test_service.py

… and client (#1471) (#1474) (cherry picked from commit 4859c8a) Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

… and client (backport #1471) (#1475) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

… and client (backport #1471) (#1476) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

… and client (ros2#1471) Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Błażej Sowa <bsowa123@gmail.com>

Add logger_name property to subscription, publisher, service and client

67d9396

Signed-off-by: Nadav Elkabets <elnadav12@gmail.com>

nadavelkabets mentioned this pull request Jun 21, 2025

Feature: new asyncio executor #1399

Open

nadavelkabets changed the title ~~feature: add logger_name property to subscription, publisher, service and client~~ Feature: add logger_name property to subscription, publisher, service and client Jun 21, 2025

fujitatomoya approved these changes Jun 23, 2025

View reviewed changes

fujitatomoya requested a review from ahcorde June 23, 2025 23:19

fujitatomoya assigned nadavelkabets Jun 23, 2025

nadavelkabets commented Jun 24, 2025

View reviewed changes

rclpy/src/rclpy/service.cpp Outdated Show resolved Hide resolved

nadavelkabets commented Jun 24, 2025

View reviewed changes

rclpy/test/test_publisher.py Outdated Show resolved Hide resolved

ahcorde and others added 2 commits June 24, 2025 09:02

Update rclpy/test/test_publisher.py

cc028db

Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

Update rclpy/src/rclpy/service.cpp

5283bd3

Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

ahcorde approved these changes Jun 24, 2025

View reviewed changes

ahcorde merged commit 4859c8a into ros2:rolling Jun 24, 2025
3 checks passed

mergify bot mentioned this pull request Jun 24, 2025

Feature: add logger_name property to subscription, publisher, service and client (backport #1471) #1474

Merged

This was referenced Jun 24, 2025

Feature: add logger_name property to subscription, publisher, service and client (backport #1471) #1475

Merged

Feature: add logger_name property to subscription, publisher, service and client (backport #1471) #1476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: add logger_name property to subscription, publisher, service and client#1471

Feature: add logger_name property to subscription, publisher, service and client#1471
ahcorde merged 3 commits intoros2:rollingfrom
nadavelkabets:feature/get-logger

nadavelkabets commented Jun 21, 2025 •

edited

Loading

Uh oh!

fujitatomoya left a comment

Uh oh!

fujitatomoya commented Jun 23, 2025

Uh oh!

fujitatomoya commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

nadavelkabets commented Jun 24, 2025

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

mergify bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nadavelkabets commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fujitatomoya left a comment

Choose a reason for hiding this comment

Uh oh!

fujitatomoya commented Jun 23, 2025

Uh oh!

fujitatomoya commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

nadavelkabets commented Jun 24, 2025

Uh oh!

ahcorde commented Jun 24, 2025

Uh oh!

mergify bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nadavelkabets commented Jun 21, 2025 •

edited

Loading

mergify bot commented Jun 24, 2025 •

edited

Loading