Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2025

Description

Fixes #1467
Fixes #1405
Fixes #1462

Is this user-facing behavior change?

  • The _pending() method in Future has been renamed to pending()
  • The user no longer has to do any workarounds with waking up the executor when a coroutine gets stuck awaiting a future that is already finished.

Did you use Generative AI?

Some of the comments and docstrings might be partially written by Github Copilot.

Additional Information

For #1467, I propagate a guard condition from a task to the awaited future and add this guard condition to the wait set in the executor. When a future is completed by an entity not controller by the executor (e.g. a separate thread), the guard condition is triggered and wakes up the executor so it can resume the task.

For #1405, I just had to make sure the task is not yielded from _wait_for_ready_callbacks when it is not ready to be resumed, hence the Task.ready() method.

EDIT: Check this comment


This is an automatic backport of pull request #1469 done by [Mergify](https://mergify.com).

Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
Signed-off-by: Nadav Elkabets <elnadav12@gmail.com>
Co-authored-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com>
(cherry picked from commit 9695271)
@ahcorde
Copy link
Contributor

ahcorde commented Dec 3, 2025

Pulls: #1553
Gist: https://gist.githubusercontent.com/ahcorde/f1bd6edae4889fc909f582f6dc07f572/raw/876fef49b9666df3c8ba6e78c400ceb7f6e403e6/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17674

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@bjsowa
Copy link
Contributor

bjsowa commented Dec 4, 2025

@ahcorde Are the failing sros2 tests my fault or are these unrelated?

@ahcorde ahcorde merged commit e137f85 into kilted Dec 8, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-1469 branch December 8, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants