-
Notifications
You must be signed in to change notification settings - Fork 275
Prevents the Future result from being set twice. #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
e2666eb to
5e95dc8
Compare
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this patch is created because of #1469, but i think this is generic fix to all the downstream distros.
|
Pulls: #1599 |
|
@Mergifyio backport kilted jazzy humble |
✅ Backports have been createdDetails
Cherry-pick of a348801 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801)
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801)
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit a348801) # Conflicts: # rclpy/rclpy/action/server.py
Description
Fixes #1598
Is this user-facing behavior change?
Yes, but this fixes the behavior that has been changed by #1469
Did you use Generative AI?
Yes, Copilot Claude Sonnet 4.5
Additional Information