Skip to content

Conversation

@fujitatomoya
Copy link
Collaborator

Description

Fixes #1598

Is this user-facing behavior change?

Yes, but this fixes the behavior that has been changed by #1469

Did you use Generative AI?

Yes, Copilot Claude Sonnet 4.5

Additional Information

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this patch is created because of #1469, but i think this is generic fix to all the downstream distros.

@fujitatomoya fujitatomoya requested a review from ahcorde February 4, 2026 11:56
@fujitatomoya fujitatomoya self-assigned this Feb 4, 2026
@ahcorde
Copy link
Contributor

ahcorde commented Feb 4, 2026

Pulls: #1599
Gist: https://gist.githubusercontent.com/ahcorde/445bb8206b3c974d83e6705b8e5594e6/raw/b5acd828317798ce9a1f6501695924ecadc5a724/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18119

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

  • Linux-rhel Build Status

@fujitatomoya fujitatomoya merged commit a348801 into rolling Feb 4, 2026
2 of 3 checks passed
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2026

backport kilted jazzy humble

✅ Backports have been created

Details

Cherry-pick of a348801 has failed:

On branch mergify/bp/humble/pr-1599
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit a348801.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclpy/rclpy/action/server.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
(cherry picked from commit a348801)
mergify bot pushed a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
(cherry picked from commit a348801)
mergify bot pushed a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
(cherry picked from commit a348801)

# Conflicts:
#	rclpy/rclpy/action/server.py
ahcorde pushed a commit that referenced this pull request Feb 5, 2026
(cherry picked from commit a348801)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
ahcorde pushed a commit that referenced this pull request Feb 6, 2026
(cherry picked from commit a348801)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Nadav Elkabets <elnadav12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Server - MultiThreadedExecutor

3 participants