Calculate the next power-of-two for the user in hash_map_init.#420
Merged
clalancette merged 4 commits intorollingfrom Apr 11, 2023
Merged
Calculate the next power-of-two for the user in hash_map_init.#420clalancette merged 4 commits intorollingfrom
clalancette merged 4 commits intorollingfrom
Conversation
That is, we allow the user to specify non powers of two, and then we do the calculation for them. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
Also @methylDragon FYI; assuming we take this, you'll be able to drop some of your code from ros2/rosidl#728 |
fujitatomoya
approved these changes
Apr 6, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
approved these changes
Apr 6, 2023
Contributor
|
I just tried the next_power_of_two again, and now I'm getting I'm not sure why bit twiddling isn't working here :/ |
methylDragon
requested changes
Apr 7, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: methylDragon <methylDragon@gmail.com>
methylDragon
requested changes
Apr 7, 2023
Contributor
methylDragon
left a comment
methylDragon
left a comment
There was a problem hiding this comment.
One more change... Sorry
methylDragon
approved these changes
Apr 9, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: methylDragon <methylDragon@gmail.com>
Contributor
Author
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, we allow the user to specify non powers of two, and then we do the calculation for them.
@wjwwood FYI.