Type hash distribution during discovery (rep2011)#104
Merged
clalancette merged 9 commits intoros2:rollingfrom Mar 26, 2023
Merged
Type hash distribution during discovery (rep2011)#104clalancette merged 9 commits intoros2:rollingfrom
clalancette merged 9 commits intoros2:rollingfrom
Conversation
14 tasks
emersonknapp
changed the title
clalancette
requested changes
Mar 15, 2023
emersonknapp
force-pushed
the
emersonknapp/type-version-hash
branch
from
63f81ff to
1c54066
Compare
clalancette
requested changes
Mar 16, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Two small changes, this otherwise looks good to me.
Contributor
Author
|
Same run combined for PRs ros2/rmw_dds_common#70 ros2/rmw_fastrtps#671 ros2/rmw_cyclonedds#437 #104 Gist: https://gist.githubusercontent.com/emersonknapp/597121a37b82d9418b14472de760c8f0/raw/b0412d81c2ae2368cb592c810496d6f92650ad68/ros2.repos
|
This was referenced Mar 17, 2023
clalancette
approved these changes
Mar 17, 2023
emersonknapp
force-pushed
the
emersonknapp/type-version-hash
branch
from
5ff54f7 to
4290374
Compare
Contributor
Author
|
emersonknapp
force-pushed
the
emersonknapp/type-version-hash
branch
from
4290374 to
4efe847
Compare
wjwwood
approved these changes
Mar 23, 2023
clalancette
approved these changes
Mar 24, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/type-version-hash
branch
from
c1f26b2 to
4e527bd
Compare
Contributor
Author
|
Gist: https://gist.githubusercontent.com/emersonknapp/c36ca5985030eccbcaac0d0384236fbd/raw/374f6ef848452efc7e6a2b079129195ece75aeec/ros2.repos
|
Contributor
|
CI is in ros2/rmw_dds_common#70 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Depends on ros2/rosidl#729
Depends on ros2/rmw_dds_common#70
Features:
rmw_dds_commonrmw_topic_endpoint_info_t.type_hash